Review Request 128460: ktp-text-ui: Added a filter for geo uri support

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jul 15 10:57:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128460/#review97439
-----------------------------------------------------------



I really like the idea!


filters/geopoint/geopoint-filter.cpp (line 34)
<https://git.reviewboard.kde.org/r/128460/#comment65742>

    Can we maybe use something that is more free software friendly than Google Maps?


- Aleix Pol Gonzalez


On July 15, 2016, 11:18 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128460/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 11:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Added a geopoint filter which adds an iframe with a map for each geo:<double,double> in message.
> 
> I tried to use openstreetmap, but had no success. I would like to add an option to select osm or google maps, but I have no time to do it now.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt 8118b13 
>   filters/geopoint/CMakeLists.txt PRE-CREATION 
>   filters/geopoint/geopoint-filter.h PRE-CREATION 
>   filters/geopoint/geopoint-filter.cpp PRE-CREATION 
>   filters/geopoint/ktptextui_message_filter_geopoint.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128460/diff/
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160715/113da147/attachment-0001.html>


More information about the KDE-Telepathy mailing list