telepathy-qt-service library fix link errors or make shared?

[Alexandr Akulich]

Hi.

How do you pass the -fPIC option? Does the patch fix the problem if we
change CMAKE_SHARED_LIBRARY_C_FLAGS to CMAKE_SHARED_LIBRARY_CXX_FLAGS?

I would like to take (push to fd.o) the patch, which fixes fPIC, but
we need to have a proper review and more fix confirmation.

Still, probably it's a time to make telepathy-qt-service to be a shared library.
What's about pushing the two commits to the freedesktop.org repository
(https://github.com/TelepathyQt/telepathy-qt/commit/5eeddedd04c9a4d18c92b4eb5aa494d7abc9a1d5,
https://github.com/TelepathyQt/telepathy-qt/commit/2ff93cd0c0b73e2fc07d9ecbc115460224a1cbd1)?
Sure, I would take care on so versions.

I would like to include this into 0.9.7 release.

On Sat, Jan 16, 2016 at 1:52 AM, Rex Dieter <rdieter at math.unl.edu> wrote:
> Diane Trout wrote:
>
>> Hi,
>>
>> Daniel Pocock wrote another telepathy SIP connection manager, and he'd
>> like to use the telepathy-qt-service library.
>>
>> In the cmake file it says "compile as a static library until there's a
>> stable API"
>>
>> However when he tried to link against it he got -fPIC errors
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801817
>
> I used this,
> http://pkgs.fedoraproject.org/cgit/rpms/telepathy-qt.git/tree/telepathy-qt-0.9.5-static_fPIC.patch
>
> (sorry I suck for not working harder to upstream it, though I'm not 100%
> certain that's the right way to fix it either)
>
> -- Rex
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy