Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123504/
-----------------------------------------------------------

(Updated April 15, 2016, 8:56 a.m.)


Review request for Telepathy.


Changes
-------

1) Fix player status message not updating when the status message template changes.
2) Watch for ownership changes on the service name. This fixes VLC player multiple instances.
3) Clear m_serviceNames on plugin disable, and remove players that disappear from DBus. Reverse the key/value ordering.
4) serviceOwnerChanged() if .. then merge identical conditions.
5) m_watchedPlayers, m_serviceNames QMap -> QHash.
6) Revert default status message template change.
7) Comment clarification.


Repository: ktp-kded-module


Description (updated)
-------

New features:
-Much improved multiple player handling; a number of service availability bugs were fixed.
-Ignore tracks with inadequate metadata
-Separator for empty metadata info fields with (currently) hidden config


Diffs (updated)
-----

  telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
  telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 

Diff: https://git.reviewboard.kde.org/r/123504/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160415/b5170ca3/attachment.html>