Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

[Martin Klapetek]

> On April 8, 2016, 1:08 a.m., David Edmundson wrote:
> > telepathy-mpris.cpp, line 132
> > <https://git.reviewboard.kde.org/r/123504/diff/2/?file=448086#file448086line132>
> >
> >     In English that makes it sound like the other person is physically playing the song with guitars and stuff.
> >     
> >     listening is the better verb to describe what the _person_ is doing which is what you want in your status message.
> 
> James Smith wrote:
>     'Now playing' better accomodates videos with metadata, which otherwise would require a simple type of support to be ignored.
>     
>     We could:
>     1) Keep the current default template and leave it up to the user to change the template to accomodate video metadata.
>     2) Use a more generic approach like the one in this patch.
>     3) Do the minimum required to ignore videos.
>     4) Provide a separate template for videos.
>     
>     A mimetype lookup from filename can be done on playback change, xesam:url isn't required but is implemented by most players. IMO the mpris specification should at least clarify xesam:Media(filetype:audio or filetype:video) for the metadata field.

> 'Now playing' better accomodates videos with metadata,

We have discussed this already. Video+mpris is a nonsense. Please drop it.

https://git.reviewboard.kde.org/r/121641/


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123504/#review94413
-----------------------------------------------------------


On March 7, 2016, 7:52 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123504/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 7:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> New features:
> -Much improved multiple player handling; a number of service availability bugs were fixed.
> -Default template changed from 'Now Listening to ...'  to 'Now Playing ...'
> -Ignore tracks with inadequate metadata
> -Separator for empty metadata info fields with (currently) hidden config
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
> 
> Diff: https://git.reviewboard.kde.org/r/123504/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160411/b2e215f3/attachment.html>