Review Request 125103: BUG 345446: log-viewer shows "There are no logs for this day"

[Alexandre Martins]

> On sep. 21, 2015, 10:41 après-midi, Daniel Vrátil wrote:
> > KTp/Logger/plugins/tplogger/pending-tp-logger-logs.cpp, line 64
> > <https://git.reviewboard.kde.org/r/125103/diff/1/?file=402227#file402227line64>
> >
> >     I am not convinced this will work. Tpl::Event can also be Tpl::CallEvent, in which case staticCast will be successful, but dereferencing anything from Tpl::TextEventPtr will just give us garbage data, or crash.
> >     
> >     If the problem is in TpLoggerQt, we should fix it there (we can do that easily, that project is maintained by KTp people too), rather than working around that in KTpLogger.

I agree. It will be better.

I made this proposal because I didn't know the code. It's just a dirty quick fix :-/


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125103/#review85731
-----------------------------------------------------------


On sep. 8, 2015, 11:19 matin, Alexandre Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125103/
> -----------------------------------------------------------
> 
> (Updated sep. 8, 2015, 11:19 matin)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 345446
>     http://bugs.kde.org/show_bug.cgi?id=345446
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> ktp-log-viewer: unable to read logs
> 
> This is due to function "PendingEvents::Private::storeAndFreeEvent" ( project: telepathy-logger-qt4, file: TelepathyLoggerQt4/pending-events.cpp) that push TextEvent into a list of event that made a staticCast too.
> 
> ----- code snip -----
> TextEventPtr eventPtr = TextEventPtr::wrap(TPL_TEXT_EVENT(tplEvent), true);
> self->mPriv->events << eventPtr;
> ---------------------
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/plugins/tplogger/pending-tp-logger-logs.cpp 69e342677dc747b419c18e4372b555ab4dfa0a48 
> 
> Diff: https://git.reviewboard.kde.org/r/125103/diff/
> 
> 
> Testing
> -------
> 
> I run under FreeBSD with version 0.8.0, but I'm able to see log in both log-viewer and chat window.
> 
> 
> Thanks,
> 
> Alexandre Martins
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150924/44a61f17/attachment.html>