Review Request 125146: Call parent ::event()

Albert Astals Cid aacid at kde.org
Thu Sep 10 21:01:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125146/
-----------------------------------------------------------

Review request for Telepathy and Martin Klapetek.


Repository: ktp-text-ui


Description
-------

::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work

In this case it probably doesn't matter, but it's always good to have "good code"


Diffs
-----

  lib/chat-search-bar.cpp f0a559f 

Diff: https://git.reviewboard.kde.org/r/125146/diff/


Testing
-------


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150910/2491af97/attachment.html>


More information about the KDE-Telepathy mailing list