Review Request 125467: TpChannel closed doesn't seem to be emitted when clicking hangup.

[Diane Trout]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125467/
-----------------------------------------------------------

(Updated Nov. 14, 2015, 9:47 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy.


Repository: ktp-call-ui


Description
-------

This forces it to hang up and includes some guard conditions
as some pointers get accessed after they've already been destroyed. 

However there may be a better solution as part of this hack happens because the TpChannel closed signal doesn't seem to be emitted when ktp-call-ui triggers destroying the farstream pipeline.


Diffs
-----

  libktpcall/private/tf-audio-content-handler.cpp 1dd797bfb1a53c52eb6a0c8a9671ee6a54551af2 
  libktpcall/private/tf-channel-handler.cpp 1a0a0dcc7afb390d4ed40fb57cbaece82ea3d3b5 

Diff: https://git.reviewboard.kde.org/r/125467/diff/


Testing
-------

Called music at iptel.org pressed hangup. experienced fewer segfaults.


Thanks,

Diane Trout

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20151115/287c9f28/attachment.html>