Review Request 125467: TpChannel closed doesn't seem to be emitted when clicking hangup.

[Diane Trout]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125467/#review88371
-----------------------------------------------------------


This patch is confusing two different issues.

There's a bunch of ways pointers can be set null and still get accessed which causes crashes.

Also hanging up is slow, so I may have caused my signal problems by just not waiting long enough. But I should test that seperately.

- Diane Trout


On Sept. 30, 2015, 11:33 p.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125467/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 11:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> This forces it to hang up and includes some guard conditions
> as some pointers get accessed after they've already been destroyed. 
> 
> However there may be a better solution as part of this hack happens because the TpChannel closed signal doesn't seem to be emitted when ktp-call-ui triggers destroying the farstream pipeline.
> 
> 
> Diffs
> -----
> 
>   libktpcall/private/tf-audio-content-handler.cpp 1dd797bfb1a53c52eb6a0c8a9671ee6a54551af2 
>   libktpcall/private/tf-channel-handler.cpp 1a0a0dcc7afb390d4ed40fb57cbaece82ea3d3b5 
> 
> Diff: https://git.reviewboard.kde.org/r/125467/diff/
> 
> 
> Testing
> -------
> 
> Called music at iptel.org pressed hangup. experienced fewer segfaults.
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20151115/1849d74c/attachment.html>