Review Request 123546: Show dialogs on button clicked (not pressed)

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123546/#review80854
-----------------------------------------------------------


> but we should not use QCommandLinkButton as it is activated on press (and there is no way to easily change it).

QCommandLinkButton derives from QPushButton, it has exactly the same signals including clicked(); there's really no reason to change that. I'll be changing it back to QCommandLinkButton.

- Martin Klapetek


On May 11, 2015, 12:10 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123546/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 12:10 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: kaccounts-integration
> 
> 
> Description
> -------
> 
> Connect to QPushButton::clicked signal instead of QPushButton::pressed.
> 
> This makes it consistent with other buttons, eg. the button action is activated only when releasing the mouse inside the button rect, not immediately on mouse press.
> It is also needed to change QCommandLinkButton to QPushButton, where it changes the text alignment from left-aligned to center-aligned. I don't know how to replicate the look with
> QPushButton, but we should not use QCommandLinkButton as it is activated on press (and there is no way to easily change it).
> 
> 
> Diffs
> -----
> 
>   src/accountwidget.cpp a56cf04 
>   src/create.cpp 5e4d46e 
> 
> Diff: https://git.reviewboard.kde.org/r/123546/diff/
> 
> 
> Testing
> -------
> 
> Buttons are now activated on mouse release.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150526/473778a0/attachment.html>