Review Request 123546: Show dialogs on button clicked (not pressed)

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123546/
-----------------------------------------------------------

(Updated May 10, 2015, 10:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Martin Klapetek.


Changes
-------

Submitted with commit 47734ffd90bdd40350379ffecf7f055fb0eec9a8 by David Rosca to branch master.


Repository: kaccounts-integration


Description
-------

Connect to QPushButton::clicked signal instead of QPushButton::pressed.

This makes it consistent with other buttons, eg. the button action is activated only when releasing the mouse inside the button rect, not immediately on mouse press.
It is also needed to change QCommandLinkButton to QPushButton, where it changes the text alignment from left-aligned to center-aligned. I don't know how to replicate the look with
QPushButton, but we should not use QCommandLinkButton as it is activated on press (and there is no way to easily change it).


Diffs
-----

  src/accountwidget.cpp a56cf04 
  src/create.cpp 5e4d46e 

Diff: https://git.reviewboard.kde.org/r/123546/diff/


Testing
-------

Buttons are now activated on mouse release.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150510/88166fa9/attachment.html>