Review Request 123065: Replace "qDebug(); " with "qDebug() << Q_FUNC_INFO; "

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123065/#review77752
-----------------------------------------------------------


This should be ported to qCDebug instead and leave Q_FUNC_INFO out completely. This is (and should be) controlled by your env variables, like eg. export QT_MESSAGE_PATTERN="%{appname}(%{pid}) $c[31m%{if-debug}$c[94m%{endif}%{function}$c[0m: %{message}"

Look at for example ktp-kded-module and what it does with qCDebug.

- Martin Klapetek


On March 19, 2015, 8:14 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123065/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 8:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Replace "qDebug();" with "qDebug() << Q_FUNC_INFO;"
> 
> 
> Diffs
> -----
> 
>   libktpcall/private/sink-controllers.cpp 7ed56139feda9cc73a7366a771ebf63f0aa278bf 
>   libktpcall/private/tf-content-handler.cpp a8456e2ccce20ea3076cdd97c21ccf2c5e37c898 
>   libktpcall/private/tf-video-content-handler.cpp a8a9eca2a8eb88bb3140643f66529d410bc7087c 
>   src/approver.cpp cab426b7f1241190bb3bfa1b0062aea9e06be8b6 
>   src/call-handler.cpp 75c798491058e0bdd29b0a7618baf86b17048f5c 
>   src/call-window.cpp b4d7e3dfe0b6ded113c9ff7c226f4a3c2cf2d9f4 
> 
> Diff: https://git.reviewboard.kde.org/r/123065/diff/
> 
> 
> Testing
> -------
> 
> Builds, starts. Debug output works as expected.
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150319/ac045b74/attachment.html>