<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123065/">https://git.reviewboard.kde.org/r/123065/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should be ported to qCDebug instead and leave Q_FUNC_INFO out completely. This is (and should be) controlled by your env variables, like eg. export QT_MESSAGE_PATTERN="%{appname}(%{pid}) $c[31m%{if-debug}$c[94m%{endif}%{function}$c[0m: %{message}"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Look at for example ktp-kded-module and what it does with qCDebug.</p></pre>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On March 19th, 2015, 8:14 p.m. CET, Niels Ole Salscheider wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Niels Ole Salscheider.</div>
<p style="color: grey;"><i>Updated March 19, 2015, 8:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-call-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replace "qDebug();" with "qDebug() << Q_FUNC_INFO;"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, starts. Debug output works as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libktpcall/private/sink-controllers.cpp <span style="color: grey">(7ed56139feda9cc73a7366a771ebf63f0aa278bf)</span></li>
<li>libktpcall/private/tf-content-handler.cpp <span style="color: grey">(a8456e2ccce20ea3076cdd97c21ccf2c5e37c898)</span></li>
<li>libktpcall/private/tf-video-content-handler.cpp <span style="color: grey">(a8a9eca2a8eb88bb3140643f66529d410bc7087c)</span></li>
<li>src/approver.cpp <span style="color: grey">(cab426b7f1241190bb3bfa1b0062aea9e06be8b6)</span></li>
<li>src/call-handler.cpp <span style="color: grey">(75c798491058e0bdd29b0a7618baf86b17048f5c)</span></li>
<li>src/call-window.cpp <span style="color: grey">(b4d7e3dfe0b6ded113c9ff7c226f4a3c2cf2d9f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123065/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>