Porting TelepathyLoggerQt to Qt5

[Aleix Pol]

On Wed, Jan 21, 2015 at 7:53 PM, Daniel Vrátil <dvratil at redhat.com> wrote:
> On Tuesday, October 28, 2014 04:09:15 PM Aleix Pol wrote:
> <snip>
>
> Hi all,
>
>> > >
>> > > Ok, so what do we do about that? Qt5 in master?
>> > > Who needs to be told?
>> >
>> > I am not familiar with KTp release plans (sadly I haven't been around this
>> > project much lately) - but if next release is going to be Qt5-based, the
>> > merging can happen at any point, after we solve the following:
>> >
>> > Version number: I made TelepathyLoggerQt versioning follow upstream
>> > (TelepathyLogger), but now we would have to diverge as 0.8 is Qt4 build...
>>
>> Sure :)
>
> *shrug* any ideas here?
Ideas about what? :)

>
>>
>> > Merge noqtglib: I've ported away from QtGLib on the KTp sprint in May, but
>> > the
>> > branch did not get merged, because I....kinda forgot about it. Since it's
>> > an
>> > ABI break, this is a good point to merge it. But could also happen after
>> > merging Qt 5 to master, so not really important at this point.
>>
>> I would say it's fine if you merge it right now in the qt5 branch.
>
> It took me only 3 months to do git merge and resolve couple conflicts, yay for
> me! But qt5 branch is finally QtGlib free, which is good news I suppose.
>
> I also posted a patch which ports the qt5 branch to ECM and makes the
> buildsystem much easier to understand and maintain now, so please someone
> review it. It's a Dan-sized patch, but it removes a lots of code, so it's
> good, right? :-)
>
> Cheers,
> Dan
Sounds great to me :)

>
>> > CI requirements: we now require TelepathyQt5, so we have to check with
>> > sysadmins first whether it is available on the CI. Apparently we have
>> > telepathy-qt4 builds on the CI, so we probably should ask them to add
>> > telepathy-qt5 builds and build against them (?).
>>
>> Sure, we actually need to take into account the CI for KTp altogether
>> anyway...
>>
>> Aleix
>
> --
> Daniel Vrátil | dvratil at redhat.com | dvratil on #kde-devel, #kontact, #akonadi
> Software Engineer - KDE Desktop Team, Red Hat Inc.
>
> GPG Key: 0xC59D614F6F4AE348
> Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>