Review Request 122188: Port to ECM

Daniel Vrátil dvratil at redhat.com
Wed Jan 21 18:52:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122188/
-----------------------------------------------------------

Review request for Telepathy.


Repository: telepathy-logger-qt


Description
-------

Port TelepathyLoggerQt to ECM. It makes the buildsystem much simpler and actually maintainable.


Diffs
-----

  CMakeLists.txt eeab51838d6782d371d0fea51fe3c31d500ca4bb 
  TelepathyLoggerQt/CMakeLists.txt 8c84f290f7065a255d34b3ecb9129a53db393029 
  TelepathyLoggerQt/CallEvent ddac7fb249148b11a128a7b176ea8610607a6b68 
  TelepathyLoggerQt/call-event.cpp fd3a3ec400ea64a4f1125770473f52df6774f637 
  TelepathyLoggerQt/entity.h 2a2520a3d9891d88e1c708379123bcc8dcf22bca 
  TelepathyLoggerQt/entity.cpp 8c378934df598cbeb1ea9a176fbcc60646e9d912 
  TelepathyLoggerQt/event.h 96c275a6a075a434877c3ef416f4edb38bf89a08 
  TelepathyLoggerQt/event.cpp 15c1ae1c9608b13265f73b0c4da3ddb87f8f1f24 
  TelepathyLoggerQt/global.h 491861f42018b64ccfcb0d0ba038090b3f41b3f4 
  TelepathyLoggerQt/init.h 684853968ec24f32502f2149e16a1000a152b8cc 
  TelepathyLoggerQt/init.cpp 7e925b3e22a26970b6e8ef9797197a45bf1cfbdc 
  TelepathyLoggerQt/log-manager.h 36796605df69ab1c775e0b187e00385ee4e7c436 
  TelepathyLoggerQt/log-manager.cpp b113d4dc928d5d0eaf8bb24b4171ff932da64206 
  TelepathyLoggerQt/log-walker.h a2ef313c2243d6c8074c2eff8f05516897857ad7 
  TelepathyLoggerQt/log-walker.cpp 7add228ee2abdf68e1eccf744545c946613383b6 
  TelepathyLoggerQt/object.h 4f140b16e84a82e0bdedd4a2d4888ad4cea02f76 
  TelepathyLoggerQt/pending-clear.h 75c88bd52acdecb346a97bd62e1bb956260a8471 
  TelepathyLoggerQt/pending-clear.cpp e26c7195dfb0b464ef3457e39b073f8639360d52 
  TelepathyLoggerQt/pending-dates.h ba2772bdbda66f54eff8cd8f52eeba5359a2437e 
  TelepathyLoggerQt/pending-dates.cpp d690c3c5b95938cde49b25cefb1f4fe3dd6e6cb4 
  TelepathyLoggerQt/pending-entities.h 325c9fbdab6504a31c8497c30430b35107f0e29c 
  TelepathyLoggerQt/pending-entities.cpp 7b3f0a828d12b06e12998f92399db020714af283 
  TelepathyLoggerQt/pending-events.h a87c88447c7eeb21dcc3e124cf86cbf1ea84a643 
  TelepathyLoggerQt/pending-events.cpp 143f609366ffb83ceafc4e4fcfc606dd9b2277eb 
  TelepathyLoggerQt/pending-log-walker-operation.h 531a37da89695f227febd928f8cc36f7b6ca5576 
  TelepathyLoggerQt/pending-log-walker-operation.cpp 46f82e486fb49dcedfbb74a6dfdddecf14de4f5a 
  TelepathyLoggerQt/pending-operation.h d48d941852acff0042be256cc4b41156e07d5a4b 
  TelepathyLoggerQt/pending-operation.cpp da302f35b3dda44b8cb5c45c3caf6bb998217ac9 
  TelepathyLoggerQt/pending-search.h ab4b246ff2c9772297cc379b93065e1fa54ca9bc 
  TelepathyLoggerQt/pending-search.cpp db3076e4ea7054ff2905b771db11b85b3129d02b 
  TelepathyLoggerQt/search-hit.h f12d6940da6cc099d183fcd583f07d4a3c66c386 
  TelepathyLoggerQt/search-hit.cpp 50ab25fc722b48d0bd3d47dac3ade5cf393dc30c 
  TelepathyLoggerQt/text-event.h 0a9d410d7c6d3316a5fea5c3ba01307e01e0e9c5 
  TelepathyLoggerQt/text-event.cpp ea5be4186a74f6650c8b6970ac7e6c960525470d 
  TelepathyLoggerQt/types.h 36700759121a690044d338d20ab06999f87df49c 
  TelepathyLoggerQt/utils.h 378fb23759828f998f5abccec8c543abd77ca7dd 
  TelepathyLoggerQt/utils.cpp e39b49492b4c95dbdc6e3c572cd5f3ef4d76fc22 
  cmake/modules/BasicFindPackageVersion.cmake.in 2be6d9ecda4b04bc99f259748fd499d15ded5ef8 
  cmake/modules/InstallSettings.cmake b8a79bbc1423f190753efcd4b6dd35f5beadc58f 
  cmake/modules/MacroWriteBasicCMakeVersionFile.cmake d23d857b46e9c8cf1561597fb1843624aea0f281 
  cmake/modules/Qt5Macros.cmake e7eb0cbe044ecce7bb8aa2c23a3066684770a064 
  cmake/modules/QtMacros.cmake 9f8f9985f398a9e7421ffff02f96eafe6d6b765a 
  cmake/modules/TelepathyDefaults.cmake b926246ec9e152f85b3e0c1730ceac4c2184352f 
  cmake/modules/TelepathyDist.cmake 8d6faddd2f09a2631734b6a0fdaaf95e9d0a88df 
  TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in ca7f0cc4c9b2a8b4c242a753211478325399445e 
  TelepathyLoggerQt/TextEvent 98072c14956a45bbee2413c4e721b5c7f6e43f36 
  TelepathyLoggerQt/Types 471c1413d552b7f6e3030343ebc7ddbf04bbdcbf 
  TelepathyLoggerQt/call-event.h e820a2e2b34727a7f2aa8540b919f919c3315988 
  TelepathyLoggerQt/Entity 4f1f0b7fb166ccb6311c46a184d4c992cca5e38b 
  TelepathyLoggerQt/Event 2a0e8edeb7d5956d6c9ba6106a9a4125775e00e5 
  TelepathyLoggerQt/Global ecf1d7d656acecc56341a3559e54337a08761232 
  TelepathyLoggerQt/Init f8a24306ba5e0143c9d98b53da7e031631249ecd 
  TelepathyLoggerQt/LogManager 580cf87c70c89d911fc99e7c6410c1fcefa5f7af 
  TelepathyLoggerQt/LogWalker bd2a0fefb4ba8d5b92e5838eb9ae8db658bdb336 
  TelepathyLoggerQt/Object 3dd41b247b2f12b6678ea3613d4463cb9c9d6142 
  TelepathyLoggerQt/PendingDates 46ffe6eb7183acb5df4a859d27eb6d1ddf016e3b 
  TelepathyLoggerQt/PendingEntities 7007da7c83c02958493d755cb7151a080e4d0e6b 
  TelepathyLoggerQt/PendingEvents df4c775a369244adc8f2871e9c5129e8db58d132 
  TelepathyLoggerQt/PendingOperation 5521ac5193b0e1d3310b80adf60ddbc0ee2701b5 
  TelepathyLoggerQt/PendingSearch 7b387881c9c9b088eaf0d10601e927886249aea3 
  TelepathyLoggerQt/SearchHit f05782ebed423424acfa575c0b4e33ead67fc4d1 

Diff: https://git.reviewboard.kde.org/r/122188/diff/


Testing
-------

Built TpLoggerQt with this patch, built k-c-i against it, tried accessing logs from ktp-log-viewer...and it worked!


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150121/3255f7ee/attachment.html>


More information about the KDE-Telepathy mailing list