<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122188/">https://git.reviewboard.kde.org/r/122188/</a>
     </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Daniel Vrátil.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
telepathy-logger-qt
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port TelepathyLoggerQt to ECM. It makes the buildsystem much simpler and actually maintainable.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built TpLoggerQt with this patch, built k-c-i against it, tried accessing logs from ktp-log-viewer...and it worked!</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(eeab51838d6782d371d0fea51fe3c31d500ca4bb)</span></li>

 <li>TelepathyLoggerQt/CMakeLists.txt <span style="color: grey">(8c84f290f7065a255d34b3ecb9129a53db393029)</span></li>

 <li>TelepathyLoggerQt/CallEvent <span style="color: grey">(ddac7fb249148b11a128a7b176ea8610607a6b68)</span></li>

 <li>TelepathyLoggerQt/call-event.cpp <span style="color: grey">(fd3a3ec400ea64a4f1125770473f52df6774f637)</span></li>

 <li>TelepathyLoggerQt/entity.h <span style="color: grey">(2a2520a3d9891d88e1c708379123bcc8dcf22bca)</span></li>

 <li>TelepathyLoggerQt/entity.cpp <span style="color: grey">(8c378934df598cbeb1ea9a176fbcc60646e9d912)</span></li>

 <li>TelepathyLoggerQt/event.h <span style="color: grey">(96c275a6a075a434877c3ef416f4edb38bf89a08)</span></li>

 <li>TelepathyLoggerQt/event.cpp <span style="color: grey">(15c1ae1c9608b13265f73b0c4da3ddb87f8f1f24)</span></li>

 <li>TelepathyLoggerQt/global.h <span style="color: grey">(491861f42018b64ccfcb0d0ba038090b3f41b3f4)</span></li>

 <li>TelepathyLoggerQt/init.h <span style="color: grey">(684853968ec24f32502f2149e16a1000a152b8cc)</span></li>

 <li>TelepathyLoggerQt/init.cpp <span style="color: grey">(7e925b3e22a26970b6e8ef9797197a45bf1cfbdc)</span></li>

 <li>TelepathyLoggerQt/log-manager.h <span style="color: grey">(36796605df69ab1c775e0b187e00385ee4e7c436)</span></li>

 <li>TelepathyLoggerQt/log-manager.cpp <span style="color: grey">(b113d4dc928d5d0eaf8bb24b4171ff932da64206)</span></li>

 <li>TelepathyLoggerQt/log-walker.h <span style="color: grey">(a2ef313c2243d6c8074c2eff8f05516897857ad7)</span></li>

 <li>TelepathyLoggerQt/log-walker.cpp <span style="color: grey">(7add228ee2abdf68e1eccf744545c946613383b6)</span></li>

 <li>TelepathyLoggerQt/object.h <span style="color: grey">(4f140b16e84a82e0bdedd4a2d4888ad4cea02f76)</span></li>

 <li>TelepathyLoggerQt/pending-clear.h <span style="color: grey">(75c88bd52acdecb346a97bd62e1bb956260a8471)</span></li>

 <li>TelepathyLoggerQt/pending-clear.cpp <span style="color: grey">(e26c7195dfb0b464ef3457e39b073f8639360d52)</span></li>

 <li>TelepathyLoggerQt/pending-dates.h <span style="color: grey">(ba2772bdbda66f54eff8cd8f52eeba5359a2437e)</span></li>

 <li>TelepathyLoggerQt/pending-dates.cpp <span style="color: grey">(d690c3c5b95938cde49b25cefb1f4fe3dd6e6cb4)</span></li>

 <li>TelepathyLoggerQt/pending-entities.h <span style="color: grey">(325c9fbdab6504a31c8497c30430b35107f0e29c)</span></li>

 <li>TelepathyLoggerQt/pending-entities.cpp <span style="color: grey">(7b3f0a828d12b06e12998f92399db020714af283)</span></li>

 <li>TelepathyLoggerQt/pending-events.h <span style="color: grey">(a87c88447c7eeb21dcc3e124cf86cbf1ea84a643)</span></li>

 <li>TelepathyLoggerQt/pending-events.cpp <span style="color: grey">(143f609366ffb83ceafc4e4fcfc606dd9b2277eb)</span></li>

 <li>TelepathyLoggerQt/pending-log-walker-operation.h <span style="color: grey">(531a37da89695f227febd928f8cc36f7b6ca5576)</span></li>

 <li>TelepathyLoggerQt/pending-log-walker-operation.cpp <span style="color: grey">(46f82e486fb49dcedfbb74a6dfdddecf14de4f5a)</span></li>

 <li>TelepathyLoggerQt/pending-operation.h <span style="color: grey">(d48d941852acff0042be256cc4b41156e07d5a4b)</span></li>

 <li>TelepathyLoggerQt/pending-operation.cpp <span style="color: grey">(da302f35b3dda44b8cb5c45c3caf6bb998217ac9)</span></li>

 <li>TelepathyLoggerQt/pending-search.h <span style="color: grey">(ab4b246ff2c9772297cc379b93065e1fa54ca9bc)</span></li>

 <li>TelepathyLoggerQt/pending-search.cpp <span style="color: grey">(db3076e4ea7054ff2905b771db11b85b3129d02b)</span></li>

 <li>TelepathyLoggerQt/search-hit.h <span style="color: grey">(f12d6940da6cc099d183fcd583f07d4a3c66c386)</span></li>

 <li>TelepathyLoggerQt/search-hit.cpp <span style="color: grey">(50ab25fc722b48d0bd3d47dac3ade5cf393dc30c)</span></li>

 <li>TelepathyLoggerQt/text-event.h <span style="color: grey">(0a9d410d7c6d3316a5fea5c3ba01307e01e0e9c5)</span></li>

 <li>TelepathyLoggerQt/text-event.cpp <span style="color: grey">(ea5be4186a74f6650c8b6970ac7e6c960525470d)</span></li>

 <li>TelepathyLoggerQt/types.h <span style="color: grey">(36700759121a690044d338d20ab06999f87df49c)</span></li>

 <li>TelepathyLoggerQt/utils.h <span style="color: grey">(378fb23759828f998f5abccec8c543abd77ca7dd)</span></li>

 <li>TelepathyLoggerQt/utils.cpp <span style="color: grey">(e39b49492b4c95dbdc6e3c572cd5f3ef4d76fc22)</span></li>

 <li>cmake/modules/BasicFindPackageVersion.cmake.in <span style="color: grey">(2be6d9ecda4b04bc99f259748fd499d15ded5ef8)</span></li>

 <li>cmake/modules/InstallSettings.cmake <span style="color: grey">(b8a79bbc1423f190753efcd4b6dd35f5beadc58f)</span></li>

 <li>cmake/modules/MacroWriteBasicCMakeVersionFile.cmake <span style="color: grey">(d23d857b46e9c8cf1561597fb1843624aea0f281)</span></li>

 <li>cmake/modules/Qt5Macros.cmake <span style="color: grey">(e7eb0cbe044ecce7bb8aa2c23a3066684770a064)</span></li>

 <li>cmake/modules/QtMacros.cmake <span style="color: grey">(9f8f9985f398a9e7421ffff02f96eafe6d6b765a)</span></li>

 <li>cmake/modules/TelepathyDefaults.cmake <span style="color: grey">(b926246ec9e152f85b3e0c1730ceac4c2184352f)</span></li>

 <li>cmake/modules/TelepathyDist.cmake <span style="color: grey">(8d6faddd2f09a2631734b6a0fdaaf95e9d0a88df)</span></li>

 <li>TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in <span style="color: grey">(ca7f0cc4c9b2a8b4c242a753211478325399445e)</span></li>

 <li>TelepathyLoggerQt/TextEvent <span style="color: grey">(98072c14956a45bbee2413c4e721b5c7f6e43f36)</span></li>

 <li>TelepathyLoggerQt/Types <span style="color: grey">(471c1413d552b7f6e3030343ebc7ddbf04bbdcbf)</span></li>

 <li>TelepathyLoggerQt/call-event.h <span style="color: grey">(e820a2e2b34727a7f2aa8540b919f919c3315988)</span></li>

 <li>TelepathyLoggerQt/Entity <span style="color: grey">(4f1f0b7fb166ccb6311c46a184d4c992cca5e38b)</span></li>

 <li>TelepathyLoggerQt/Event <span style="color: grey">(2a0e8edeb7d5956d6c9ba6106a9a4125775e00e5)</span></li>

 <li>TelepathyLoggerQt/Global <span style="color: grey">(ecf1d7d656acecc56341a3559e54337a08761232)</span></li>

 <li>TelepathyLoggerQt/Init <span style="color: grey">(f8a24306ba5e0143c9d98b53da7e031631249ecd)</span></li>

 <li>TelepathyLoggerQt/LogManager <span style="color: grey">(580cf87c70c89d911fc99e7c6410c1fcefa5f7af)</span></li>

 <li>TelepathyLoggerQt/LogWalker <span style="color: grey">(bd2a0fefb4ba8d5b92e5838eb9ae8db658bdb336)</span></li>

 <li>TelepathyLoggerQt/Object <span style="color: grey">(3dd41b247b2f12b6678ea3613d4463cb9c9d6142)</span></li>

 <li>TelepathyLoggerQt/PendingDates <span style="color: grey">(46ffe6eb7183acb5df4a859d27eb6d1ddf016e3b)</span></li>

 <li>TelepathyLoggerQt/PendingEntities <span style="color: grey">(7007da7c83c02958493d755cb7151a080e4d0e6b)</span></li>

 <li>TelepathyLoggerQt/PendingEvents <span style="color: grey">(df4c775a369244adc8f2871e9c5129e8db58d132)</span></li>

 <li>TelepathyLoggerQt/PendingOperation <span style="color: grey">(5521ac5193b0e1d3310b80adf60ddbc0ee2701b5)</span></li>

 <li>TelepathyLoggerQt/PendingSearch <span style="color: grey">(7b387881c9c9b088eaf0d10601e927886249aea3)</span></li>

 <li>TelepathyLoggerQt/SearchHit <span style="color: grey">(f05782ebed423424acfa575c0b4e33ead67fc4d1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122188/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>