Review Request 122391: Drop Qt5::Widgets dependency from KPeople main library

Aleix Pol Gonzalez aleixpol at kde.org
Mon Feb 2 18:26:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122391/
-----------------------------------------------------------

Review request for KDEPIM and Telepathy.


Repository: libkpeople


Description
-------

Moves the QActions facilities to KPeopleWidgets, this way KPeople organization makes more sense, as we already had a KPeopleWidgets anyway.


Diffs
-----

  src/CMakeLists.txt fb8db35 
  src/backends/abstractpersonaction.h 396190d 
  src/declarative/CMakeLists.txt 8fd4bf4 
  src/declarative/personactionsmodel.cpp 8120605 
  src/global.h 52ff586 
  src/global.cpp b5335b2 
  src/persondata.h 450f4d3 
  src/personpluginmanager.cpp 6469138 
  src/widgets/CMakeLists.txt bceca8c 
  src/widgets/actions.h PRE-CREATION 
  src/widgets/actions.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122391/diff/


Testing
-------

Seems to work, requires trivial patches to ktp-common-internals and ktp-contact-list.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150202/e6435c52/attachment.html>


More information about the KDE-Telepathy mailing list