Review Request 126251: Make joining group chat from contactlist applet work

Daniel Vrátil dvratil at kde.org
Sat Dec 5 19:48:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126251/
-----------------------------------------------------------

(Updated Dec. 5, 2015, 7:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Changes
-------

Submitted with commit a6870a827b88440180725c44ade616a791bfe924 by Dan Vrátil to branch Applications/15.12.


Repository: ktp-common-internals


Description
-------

JoinChatRoomDialog requires account factory to have Capabilities feature enabled, otherwise it does not load any accounts and chat rooms. This works when joining from contact list, but did not work when joining from contactlist applet, because TelepathyManager wasn't requesting the feature.


Diffs
-----

  KTp/Declarative/telepathy-manager.cpp a5e8f14 

Diff: https://git.reviewboard.kde.org/r/126251/diff/


Testing
-------

I can now join chat rooms from contactlist applet context menu.


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20151205/2a848450/attachment.html>


More information about the KDE-Telepathy mailing list