Review Request 126251: Make joining group chat from contactlist applet work

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126251/#review89153
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Dec. 5, 2015, 5:31 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126251/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2015, 5:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> JoinChatRoomDialog requires account factory to have Capabilities feature enabled, otherwise it does not load any accounts and chat rooms. This works when joining from contact list, but did not work when joining from contactlist applet, because TelepathyManager wasn't requesting the feature.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/telepathy-manager.cpp a5e8f14 
> 
> Diff: https://git.reviewboard.kde.org/r/126251/diff/
> 
> 
> Testing
> -------
> 
> I can now join chat rooms from contactlist applet context menu.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20151205/2bd6aed8/attachment.html>