Review Request 119955: Port auth handler SASL operation from KWallet to Accounts SSO

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119955/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 6:32 p.m.)


Review request for Telepathy.


Changes
-------

* Removed the HAVE_SSO parts
* Ported the OAuth plugins to work too
* Removed the AccountInterfaceStorage in favor of our own config file


Repository: ktp-auth-handler


Description
-------

This makes auth handler look into the SSO storage for credentials. If the password is wrong, the user is prompted for new one and if he wants to save that password, the password is overriden in SSO.


Diffs (updated)
-----

  CMakeLists.txt 5994416 
  cmake/modules/FindKAccounts.cmake PRE-CREATION 
  getcredentialsjob.h 0981115 
  getcredentialsjob.cpp 7016ede 
  sasl-auth-op.h 9808019 
  sasl-auth-op.cpp c54d662 
  x-telepathy-password-auth-operation.h 65d6462 
  x-telepathy-password-auth-operation.cpp f999748 
  x-telepathy-password-prompt.h fa8c1ce 
  x-telepathy-password-prompt.cpp b53b1f5 
  x-telepathy-sso-facebook-operation.h 921ef2a 
  x-telepathy-sso-facebook-operation.cpp a4a9dc9 
  x-telepathy-sso-google-operation.h 1fa4c3d 
  x-telepathy-sso-google-operation.cpp f678916 

Diff: https://git.reviewboard.kde.org/r/119955/diff/


Testing
-------

I created an account using KAccounts with both good and wrong password. With good password it just authenticates as expected, with wrong password I get a password prompt, entering a correct password makes it override the stored one and any further login does not spawn the password prompt again.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140901/c21028d6/attachment.html>