<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119955/">https://git.reviewboard.kde.org/r/119955/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2014, 6:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Removed the HAVE_SSO parts
* Ported the OAuth plugins to work too
* Removed the AccountInterfaceStorage in favor of our own config file</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-auth-handler
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes auth handler look into the SSO storage for credentials. If the password is wrong, the user is prompted for new one and if he wants to save that password, the password is overriden in SSO.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I created an account using KAccounts with both good and wrong password. With good password it just authenticates as expected, with wrong password I get a password prompt, entering a correct password makes it override the stored one and any further login does not spawn the password prompt again.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5994416)</span></li>
<li>cmake/modules/FindKAccounts.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>getcredentialsjob.h <span style="color: grey">(0981115)</span></li>
<li>getcredentialsjob.cpp <span style="color: grey">(7016ede)</span></li>
<li>sasl-auth-op.h <span style="color: grey">(9808019)</span></li>
<li>sasl-auth-op.cpp <span style="color: grey">(c54d662)</span></li>
<li>x-telepathy-password-auth-operation.h <span style="color: grey">(65d6462)</span></li>
<li>x-telepathy-password-auth-operation.cpp <span style="color: grey">(f999748)</span></li>
<li>x-telepathy-password-prompt.h <span style="color: grey">(fa8c1ce)</span></li>
<li>x-telepathy-password-prompt.cpp <span style="color: grey">(b53b1f5)</span></li>
<li>x-telepathy-sso-facebook-operation.h <span style="color: grey">(921ef2a)</span></li>
<li>x-telepathy-sso-facebook-operation.cpp <span style="color: grey">(a4a9dc9)</span></li>
<li>x-telepathy-sso-google-operation.h <span style="color: grey">(1fa4c3d)</span></li>
<li>x-telepathy-sso-google-operation.cpp <span style="color: grey">(f678916)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119955/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>