Review Request 120860: Port away from some kdelibs4support

[Aleix Pol Gonzalez]

> On Oct. 28, 2014, 7:31 p.m., Martin Klapetek wrote:
> > KTp/wallet-interface.cpp, line 76
> > <https://git.reviewboard.kde.org/r/120860/diff/1/?file=322578#file322578line76>
> >
> >     Shouldn't this be Q_GLOBAL_STATIC?

No, you cannot declare a Q_GLOBAL_STATIC within a function, it needs global scope. From the alternatives, this one the one that looked the best.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120860/#review69334
-----------------------------------------------------------


On Oct. 28, 2014, 5:51 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120860/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 5:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Should be quite straightforward, but it's better if somebody else can look.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/pinned-contacts-model.cpp e972bee 
>   KTp/Declarative/telepathy-manager.cpp 1f7fafa 
>   KTp/Logger/log-manager.cpp 7ce4a12 
>   KTp/Models/presence-model.cpp b916ca5 
>   KTp/core.cpp 1888b35 
>   KTp/error-dictionary.cpp a6179d3 
>   KTp/logs-importer-private.cpp 74e6f46 
>   KTp/message-filter-config-manager.cpp 1224ac6 
>   KTp/message-processor.cpp b461ef8 
>   KTp/wallet-interface.cpp 575cdf1 
>   kpeople/datasourceplugin/im-persons-data-source.cpp a005de9 
>   kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp f87253d 
>   otr-proxy/KTpProxy/otr-config.cpp c969172 
> 
> Diff: https://git.reviewboard.kde.org/r/120860/diff/
> 
> 
> Testing
> -------
> 
> Not much, everything still builds, can run the components I've tried.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141029/c9dbd696/attachment.html>