<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120860/">https://git.reviewboard.kde.org/r/120860/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 28th, 2014, 7:31 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120860/diff/1/?file=322578#file322578line76" style="color: black; font-weight: bold; text-decoration: underline;">KTp/wallet-interface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">WalletInterfacePrivate::WalletInterfacePrivate() :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">K_GLOBAL_STATIC</span></span><span class="p"><span class="hl">(</span></span><span class="n">KTp</span><span class="o">::</span><span class="n">WalletInterface</span><span class="p"><span class="hl">,</span></span> <span class="n">s_instance</span><span class="p"><span class="hl">)</span>;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">static</span></span><span class="hl"> </span><span class="n">KTp</span><span class="o">::</span><span class="n">WalletInterface</span> <span class="n">s_instance</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shouldn't this be Q_GLOBAL_STATIC?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, you cannot declare a Q_GLOBAL_STATIC within a function, it needs global scope. From the alternatives, this one the one that looked the best.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On October 28th, 2014, 5:51 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2014, 5:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be quite straightforward, but it's better if somebody else can look.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not much, everything still builds, can run the components I've tried.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Declarative/pinned-contacts-model.cpp <span style="color: grey">(e972bee)</span></li>
<li>KTp/Declarative/telepathy-manager.cpp <span style="color: grey">(1f7fafa)</span></li>
<li>KTp/Logger/log-manager.cpp <span style="color: grey">(7ce4a12)</span></li>
<li>KTp/Models/presence-model.cpp <span style="color: grey">(b916ca5)</span></li>
<li>KTp/core.cpp <span style="color: grey">(1888b35)</span></li>
<li>KTp/error-dictionary.cpp <span style="color: grey">(a6179d3)</span></li>
<li>KTp/logs-importer-private.cpp <span style="color: grey">(74e6f46)</span></li>
<li>KTp/message-filter-config-manager.cpp <span style="color: grey">(1224ac6)</span></li>
<li>KTp/message-processor.cpp <span style="color: grey">(b461ef8)</span></li>
<li>KTp/wallet-interface.cpp <span style="color: grey">(575cdf1)</span></li>
<li>kpeople/datasourceplugin/im-persons-data-source.cpp <span style="color: grey">(a005de9)</span></li>
<li>kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp <span style="color: grey">(f87253d)</span></li>
<li>otr-proxy/KTpProxy/otr-config.cpp <span style="color: grey">(c969172)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120860/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>