Review Request 120793: Initial port of ktp-approver to Frameworks

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120793/#review69178
-----------------------------------------------------------

Ship it!


Looks good to me. Get it in a frameworks branch anyway. This week I'll be testing all ktp+kf5 together.

- Aleix Pol Gonzalez


On Oct. 25, 2014, 3:33 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120793/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2014, 3:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-approver
> 
> 
> Description
> -------
> 
> quick&dirty port. coffee didn't kick in yet, so please double check the patch
> 
> from quick glance (and not knowing the code from before; most, if not all KAboutData instances could be just ripped out, seems they where used mostly for KNotification setComponentData?)
> also ktpapproverfactory.h can now be git rm'ed
> 
> 
> Diffs
> -----
> 
>   src/tubechannelapprover.h a4dbab6 
>   src/tubechannelapprover.cpp 836ac23 
>   src/org.freedesktop.Telepathy.Client.KTp.Approver.service.in 02e92e2 
>   src/textchannelapprover.h b69e876 
>   src/textchannelapprover.cpp 67c66ce 
>   src/ktp_approver_debug.h PRE-CREATION 
>   src/ktp_approver_debug.cpp PRE-CREATION 
>   src/ktpapprovermodule.cpp 2ddd33e 
>   src/filetransferchannelapprover.cpp 43393c0 
>   src/handlewithcaller.cpp 15934a0 
>   CMakeLists.txt 59e65f3 
>   src/CMakeLists.txt 60609d8 
>   src/dispatchoperation.cpp 68ed8cc 
>   src/filetransferchannelapprover.h 8b5a1d4 
> 
> Diff: https://git.reviewboard.kde.org/r/120793/diff/
> 
> 
> Testing
> -------
> 
> builds, i get notifications for new messages...
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141027/11497082/attachment.html>