<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120793/">https://git.reviewboard.kde.org/r/120793/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good to me. Get it in a frameworks branch anyway. This week I'll be testing all ktp+kf5 together.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On October 25th, 2014, 3:33 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2014, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-approver
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">quick&dirty port. coffee didn't kick in yet, so please double check the patch</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">from quick glance (and not knowing the code from before; most, if not all KAboutData instances could be just ripped out, seems they where used mostly for KNotification setComponentData?)
also ktpapproverfactory.h can now be git rm'ed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds, i get notifications for new messages...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tubechannelapprover.h <span style="color: grey">(a4dbab6)</span></li>
<li>src/tubechannelapprover.cpp <span style="color: grey">(836ac23)</span></li>
<li>src/org.freedesktop.Telepathy.Client.KTp.Approver.service.in <span style="color: grey">(02e92e2)</span></li>
<li>src/textchannelapprover.h <span style="color: grey">(b69e876)</span></li>
<li>src/textchannelapprover.cpp <span style="color: grey">(67c66ce)</span></li>
<li>src/ktp_approver_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ktp_approver_debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ktpapprovermodule.cpp <span style="color: grey">(2ddd33e)</span></li>
<li>src/filetransferchannelapprover.cpp <span style="color: grey">(43393c0)</span></li>
<li>src/handlewithcaller.cpp <span style="color: grey">(15934a0)</span></li>
<li>CMakeLists.txt <span style="color: grey">(59e65f3)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(60609d8)</span></li>
<li>src/dispatchoperation.cpp <span style="color: grey">(68ed8cc)</span></li>
<li>src/filetransferchannelapprover.h <span style="color: grey">(8b5a1d4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120793/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>