Review Request 121112: Finish filetransfer-handler port

[Martin Klapetek]

> On Nov. 13, 2014, 6:18 p.m., David Edmundson wrote:
> > src/main.cpp, line 57
> > <https://git.reviewboard.kde.org/r/121112/diff/1/?file=327857#file327857line57>
> >
> >     I know we had this before but, won't this appear in US english as "Your names" ?
> >     
> >     You can't see the about data in ft-h anyway.

Hah, good point. Well I'll just remove it then.


> On Nov. 13, 2014, 6:18 p.m., David Edmundson wrote:
> > src/main.cpp, line 64
> > <https://git.reviewboard.kde.org/r/121112/diff/1/?file=327857#file327857line64>
> >
> >     There was a proposal to call updateActivationEnv when startkde finishes, dunno if that happened.
> >     
> >     We should check sometime

Oh, totally missed that. I'll investigate.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121112/#review70330
-----------------------------------------------------------


On Nov. 13, 2014, 6:03 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121112/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 6:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-filetransfer-handler
> 
> 
> Description
> -------
> 
> kdelibs4support free
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7dabd67 
>   src/CMakeLists.txt e2c5e3d 
>   src/filetransfer-handler.cpp a5fa677 
>   src/handle-incoming-file-transfer-channel-job.cpp efdd052 
>   src/handle-outgoing-file-transfer-channel-job.cpp af9b679 
>   src/main.cpp 03d50f0 
>   src/telepathy-base-job.cpp f1ac0e6 
> 
> Diff: https://git.reviewboard.kde.org/r/121112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141113/3e365f2c/attachment.html>