Review Request 121112: Finish filetransfer-handler port

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121112/#review70330
-----------------------------------------------------------

Ship it!



src/main.cpp
<https://git.reviewboard.kde.org/r/121112/#comment49195>

    I know we had this before but, won't this appear in US english as "Your names" ?
    
    You can't see the about data in ft-h anyway.



src/main.cpp
<https://git.reviewboard.kde.org/r/121112/#comment49194>

    There was a proposal to call updateActivationEnv when startkde finishes, dunno if that happened.
    
    We should check sometime


- David Edmundson


On Nov. 13, 2014, 5:03 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121112/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 5:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-filetransfer-handler
> 
> 
> Description
> -------
> 
> kdelibs4support free
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7dabd67 
>   src/CMakeLists.txt e2c5e3d 
>   src/filetransfer-handler.cpp a5fa677 
>   src/handle-incoming-file-transfer-channel-job.cpp efdd052 
>   src/handle-outgoing-file-transfer-channel-job.cpp af9b679 
>   src/main.cpp 03d50f0 
>   src/telepathy-base-job.cpp f1ac0e6 
> 
> Diff: https://git.reviewboard.kde.org/r/121112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141113/8d2d49aa/attachment-0001.html>