Review Request 116623: Removes duplication of call-ui window for a single channel.

[Vadim A. Misbakh-Soloviov]

> On May 15, 2014, 2:04 p.m., Vadim A. Misbakh-Soloviov wrote:
> > Wasn't it a typo in
> > >>	if (handledCallChannels.contains(callChannel)) {
> > 
> > I bet, it should be "if (!handledCallChannels.contains" (i.e. if NOT contains). Isn't it.
> > 
> > // It brakes call-ui with currently commited behaviour (it doesn't create windows/doesn't call at all).
> 
> Martin Klapetek wrote:
>     Urgh, it looks like it :S Well that's awkward.
>     
>     Mayank - fancy doing another patch fixing this? ;)
> 
> David Edmundson wrote:
>     Crap. Looks like we're making a 0.8.2.
> 
> Vadim A. Misbakh-Soloviov wrote:
>     I can make patch in a few hours if any :)
>     
>     // I need to increase my conributions count to get a right to ask for developer access ;)
> 
> Martin Klapetek wrote:
>     Oh sure, feel free to :)
>     
>     (also note that you don't get dev account just by commit count but you must have a dev that will sign your application...if you stay around and do couple good patches, we're happy to put our names there ;)
> 
> Vadim A. Misbakh-Soloviov wrote:
>     https://reviewboard.kde.org/r/118151/
>     
>     If any.
>     
>     // just set up RBTools with 6th sense and created that review req ;)
> 
> mayank jha wrote:
>     Thanks for pointing it out @Vadim.

Actually, it still need some clearance:

Now (with fixed if-condition) Dialout UI make calls just fineb but, I, for example, still being able to call same number couple times (althought, in different channels), so, in some inperpretation, windows is duplicating (two windows with two calls to same number). I just tried to call my cellphone, and, as I noticed, it was made in two separate threads: one keeps ringing, while other says that number is already busy.

Moreover, despite I don't experience original bug ever, I didn't even now: when I close dup-window (that was created by second press on "audio/videocall" buttons), call in the first window keeps going fine.


- Vadim A.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116623/#review57960
-----------------------------------------------------------


On March 18, 2014, 10:23 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116623/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 10:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 309146
>     http://bugs.kde.org/show_bug.cgi?id=309146
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> We store the channels handled by a callManager in a list, and upon a new request we check if it already exists, only if it is new we open a new call-ui window.
> 
> 
> Diffs
> -----
> 
>   src/call-handler.h 5fea003 
>   src/call-handler.cpp f4ced53 
> 
> Diff: https://git.reviewboard.kde.org/r/116623/diff/
> 
> 
> Testing
> -------
> 
> Made a video call with another person. Clicked the audio and video call buttons. The window was not duplicated.
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140515/0f15eb52/attachment.html>