Review Request 116623: Removes duplication of call-ui window for a single channel.

[mayank jha]

> On May 15, 2014, 7:04 a.m., Vadim A. Misbakh-Soloviov wrote:
> > Wasn't it a typo in
> > >>	if (handledCallChannels.contains(callChannel)) {
> > 
> > I bet, it should be "if (!handledCallChannels.contains" (i.e. if NOT contains). Isn't it.
> > 
> > // It brakes call-ui with currently commited behaviour (it doesn't create windows/doesn't call at all).
> 
> Martin Klapetek wrote:
>     Urgh, it looks like it :S Well that's awkward.
>     
>     Mayank - fancy doing another patch fixing this? ;)
> 
> David Edmundson wrote:
>     Crap. Looks like we're making a 0.8.2.
> 
> Vadim A. Misbakh-Soloviov wrote:
>     I can make patch in a few hours if any :)
>     
>     // I need to increase my conributions count to get a right to ask for developer access ;)
> 
> Martin Klapetek wrote:
>     Oh sure, feel free to :)
>     
>     (also note that you don't get dev account just by commit count but you must have a dev that will sign your application...if you stay around and do couple good patches, we're happy to put our names there ;)
> 
> Vadim A. Misbakh-Soloviov wrote:
>     https://reviewboard.kde.org/r/118151/
>     
>     If any.
>     
>     // just set up RBTools with 6th sense and created that review req ;)

Thanks for pointing it out @Vadim.


- mayank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116623/#review57960
-----------------------------------------------------------


On March 18, 2014, 3:23 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116623/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 3:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 309146
>     http://bugs.kde.org/show_bug.cgi?id=309146
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> We store the channels handled by a callManager in a list, and upon a new request we check if it already exists, only if it is new we open a new call-ui window.
> 
> 
> Diffs
> -----
> 
>   src/call-handler.h 5fea003 
>   src/call-handler.cpp f4ced53 
> 
> Diff: https://git.reviewboard.kde.org/r/116623/diff/
> 
> 
> Testing
> -------
> 
> Made a video call with another person. Clicked the audio and video call buttons. The window was not duplicated.
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140515/f34a8a3e/attachment.html>