Review Request 118045: Use requestedPresence throughtout

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118045/#review57555
-----------------------------------------------------------


There was a problem IIRC with the signal form of onRequestedPresenceChanged() not the m_globalPresence->requestedPresence(). The onRequestedPresenceChanged() signal doesn't set the presence properly when accounts are disabled in the accounts kcm. Couldn't using m_globalPresence->requestedPresence() cause problems when the requestedPresence() isn't actually what the account is set to? For instance, now, when the currentPresence() is Away and the account presence is Away, the plugin won't activate. If the requestedPresence() was at Not Available and the account moved to its best presence Away, the plugin will activate. So, that's probably an improvement. Do you know why Away was filtered as an originating presence? This doesn't work for the status message plugins because the autoaway plugin doesn't overwrite the status message with the preset away message (if there is one set), and only doesn't overwrite the status message with the preset away message (if there is one set) for Away -only-, as the originating presence.


status-handler.cpp
<https://git.reviewboard.kde.org/r/118045/#comment40044>

    #116940 also changes m_globalPresence->currentPresence() to m_globalPresence->requestedPresence(). So if that patch is picked up before this one this line may need omitting or changing.


- James Smith


On May 7, 2014, 10:29 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118045/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 10:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Use requestedPresence throughtout
> 
> Mixing current + requested will also get you in a mess as things will
> often be slightly out for a while.
> 
> 
> Diffs
> -----
> 
>   status-handler.cpp 4b9c25a 
>   autoaway.cpp 13b71a5 
> 
> Diff: https://git.reviewboard.kde.org/r/118045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140508/0c699c3d/attachment.html>