<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118045/">https://git.reviewboard.kde.org/r/118045/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There was a problem IIRC with the signal form of onRequestedPresenceChanged() not the m_globalPresence->requestedPresence(). The onRequestedPresenceChanged() signal doesn't set the presence properly when accounts are disabled in the accounts kcm. Couldn't using m_globalPresence->requestedPresence() cause problems when the requestedPresence() isn't actually what the account is set to? For instance, now, when the currentPresence() is Away and the account presence is Away, the plugin won't activate. If the requestedPresence() was at Not Available and the account moved to its best presence Away, the plugin will activate. So, that's probably an improvement. Do you know why Away was filtered as an originating presence? This doesn't work for the status message plugins because the autoaway plugin doesn't overwrite the status message with the preset away message (if there is one set), and only doesn't overwrite the status message with the preset away message (if there is one set) for Away -only-, as the originating presence.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118045/diff/1/?file=271960#file271960line129" style="color: black; font-weight: bold; text-decoration: underline;">status-handler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StatusHandler::onRequestedPresenceChanged(const KTp::Presence &presence)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_globalPresence</span><span class="o">-></span><span class="n"><span class="hl">current</span>Presence</span><span class="p">()</span> <span class="o">!=</span> <span class="n">presenceThrottle</span><span class="p">())</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_globalPresence</span><span class="o">-></span><span class="n"><span class="hl">requested</span>Presence</span><span class="p">()</span> <span class="o">!=</span> <span class="n">presenceThrottle</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">#116940 also changes m_globalPresence->currentPresence() to m_globalPresence->requestedPresence(). So if that patch is picked up before this one this line may need omitting or changing.</pre>
</div>
<br />
<p>- James Smith</p>
<br />
<p>On May 7th, 2014, 10:29 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated May 7, 2014, 10:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use requestedPresence throughtout
Mixing current + requested will also get you in a mess as things will
often be slightly out for a while.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>status-handler.cpp <span style="color: grey">(4b9c25a)</span></li>
<li>autoaway.cpp <span style="color: grey">(13b71a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>