Review Request 116880: Add PresenceManager class for use from QML

[Siddhartha Sahu]

> On March 23, 2014, 1:49 p.m., David Edmundson wrote:
> > KTp/Declarative/presence-manager.h, line 50
> > <https://git.reviewboard.kde.org/r/116880/diff/1/?file=256034#file256034line50>
> >
> >     why are we starting an enum here?

User defined enums should start at Qt::UserRole, shouldn't they?


> On March 23, 2014, 1:49 p.m., David Edmundson wrote:
> > KTp/Declarative/presence-manager.h, line 60
> > <https://git.reviewboard.kde.org/r/116880/diff/1/?file=256034#file256034line60>
> >
> >     In general properties with read/write make better QML than Q_INVOKABLE

I got as far as Q_PROPERTY(ConnectionPresenceType presence READ presence WRITE setPresence)
1) How to make this write only?
2) Is ConnectionPresenceType the correct type to use here?


> On March 23, 2014, 1:49 p.m., David Edmundson wrote:
> > KTp/Declarative/presence-manager.h, line 64
> > <https://git.reviewboard.kde.org/r/116880/diff/1/?file=256034#file256034line64>
> >
> >     Can we just add the properties to KTp::GlobalPresence and expose this class to QML, rather than wrapping it?
> >     
> >     (I've not looked, the answer may well be no)

I tried adding the same properties there and I got an "error: ‘staticMetaObject’ is not a member of ‘Tp’".


> On March 23, 2014, 1:49 p.m., David Edmundson wrote:
> > KTp/Declarative/presence-manager.cpp, line 74
> > <https://git.reviewboard.kde.org/r/116880/diff/1/?file=256035#file256035line74>
> >
> >     This won't help you when debugging.

Haha. Good enough for a WIP ^_^


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116880/#review53781
-----------------------------------------------------------


On March 22, 2014, 12:14 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116880/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 12:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> [Work in progress]
> 
> This adds a PresenceManager class to Declarative code that can be used from QML to get and set global presence.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/presence-manager.cpp PRE-CREATION 
>   KTp/Declarative/presence-manager.h PRE-CREATION 
>   KTp/Declarative/CMakeLists.txt 57025536af43279d31380f32a2827e4060686fdc 
>   KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 
> 
> Diff: https://git.reviewboard.kde.org/r/116880/diff/
> 
> 
> Testing
> -------
> 
> Is accessible from ktp-active, functions called successfully with parameters
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140329/1df5a386/attachment.html>