Review Request 116880: Add PresenceManager class for use from QML

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116880/#review53781
-----------------------------------------------------------



KTp/Declarative/presence-manager.h
<https://git.reviewboard.kde.org/r/116880/#comment37716>

    why are we starting an enum here?



KTp/Declarative/presence-manager.h
<https://git.reviewboard.kde.org/r/116880/#comment37717>

    In general properties with read/write make better QML than Q_INVOKABLE



KTp/Declarative/presence-manager.h
<https://git.reviewboard.kde.org/r/116880/#comment37718>

    Can we just add the properties to KTp::GlobalPresence and expose this class to QML, rather than wrapping it?
    
    (I've not looked, the answer may well be no)



KTp/Declarative/presence-manager.cpp
<https://git.reviewboard.kde.org/r/116880/#comment37715>

    This won't help you when debugging.


- David Edmundson


On March 21, 2014, 6:44 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116880/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 6:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> [Work in progress]
> 
> This adds a PresenceManager class to Declarative code that can be used from QML to get and set global presence.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/presence-manager.cpp PRE-CREATION 
>   KTp/Declarative/presence-manager.h PRE-CREATION 
>   KTp/Declarative/CMakeLists.txt 57025536af43279d31380f32a2827e4060686fdc 
>   KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 
> 
> Diff: https://git.reviewboard.kde.org/r/116880/diff/
> 
> 
> Testing
> -------
> 
> Is accessible from ktp-active, functions called successfully with parameters
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140323/bbc13fe5/attachment.html>