Review Request 114660: Ktp Config Connection State pane

[Thomas Pfeiffer]

On March 23, 2014, 8:38 a.m., James Smith wrote:
> > Thomas, can you comment.

I agree that combining the two groupboxes makes sense (a groupbox with only one control in it does not make sense in general). I also agree that the group name is not intuitive, since the options themselves contain neither the word "connection" nor "state". The HIG (http://techbase.kde.org/Projects/Usability/HIG/GroupBox) suggests using a frame in that case, since it has no title ("Use a frame to arrange related controls that cannot be labeled."). So, could you use that? 


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114660/#review53786
-----------------------------------------------------------


On March 23, 2014, 5:55 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114660/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 5:55 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Moves 3 connection state configurations into a single group box saving space.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp baaceff 
>   config/telepathy-kded-config.ui 18f06f3 
> 
> Diff: https://git.reviewboard.kde.org/r/114660/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> File Attachments
> ----------------
> 
> Connection states with keepAwake plugin
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/23/dcc51f7b-402e-4206-a860-af51974c5130__connectionstateswithkeepawake.png
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140324/8a8e3fbc/attachment.html>