Review Request 114660: Ktp Config Connection State pane

[James Smith]

> On March 23, 2014, 8:38 a.m., David Edmundson wrote:
> > File Attachment: Connection states with keepAwake plugin - connectionstateswithkeepawake.png
> > <https://git.reviewboard.kde.org/r/114660/#fcomment199>
> >
> >     What's with the asterisk?
> >     That's not added in the previous diff either.

Not available is one of the presences that keeps the computer awake so it's associated with the option, because if enabled the computer will stay awake. It's marked so the user knows that the AutoAway plugin will keep the machine in an awake state when Not Available so to not enable it in combination when the machine is not desired kept awake. For instance, when Not Available in Auto Away is desired without sleep supression, disable sleep suppression. Otherwise disable Not Available in AutoAway to allow suspend without having to disable keep awake and associated user-specific presence setting differences in automatic machine sleep suppression.


> On March 23, 2014, 8:38 a.m., David Edmundson wrote:
> > File Attachment: Connection states with keepAwake plugin - connectionstateswithkeepawake.png
> > <https://git.reviewboard.kde.org/r/114660/#fcomment200>
> >
> >     I don't like this title. It sounds a bit technical.
> >     
> >     Maybe we can brainstorm something better.

Maybe non-plural "states". i.e. "state".


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114660/#review53786
-----------------------------------------------------------


On March 23, 2014, 5:55 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114660/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 5:55 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Moves 3 connection state configurations into a single group box saving space.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp baaceff 
>   config/telepathy-kded-config.ui 18f06f3 
> 
> Diff: https://git.reviewboard.kde.org/r/114660/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> File Attachments
> ----------------
> 
> Connection states with keepAwake plugin
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/23/dcc51f7b-402e-4206-a860-af51974c5130__connectionstateswithkeepawake.png
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140324/4b18a071/attachment.html>