Review Request 116911: Use the newly moved PresenceModel from K-C-I

[Siddhartha Sahu]

> On March 20, 2014, 2:44 p.m., Martin Klapetek wrote:
> > presence/src/presence-applet.cpp, lines 49-54
> > <https://git.reviewboard.kde.org/r/116911/diff/1/?file=255400#file255400line49>
> >
> >     Why this change?
> 
> Siddhartha Sahu wrote:
>     It is a pedantic change. The includes are then in the order Qt -> KDE -> Tp -> KTp
> 
> Martin Klapetek wrote:
>     What we do in KDE is usually the opposite; local includes -> KDE includes -> Qt includes (from most local to most system)

Ah ok. Reading up a bit on this, going from local to system seems to be preferable as it helps detecting dependency issues.

The includes in this file do not seem to follow any of the styles though. ^_^
Anyways, leaving them as they were for now.


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116911/#review53482
-----------------------------------------------------------


On March 20, 2014, 3:37 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116911/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 3:37 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> PresenceModel was moved from ktp-contact-list to ktp-common-internals. Using that.
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.h 76a1e36a61b5e9ed8ed2b2525a1c4f3e5b470671 
>   presence/src/presence-applet.cpp 7fe049617fb426f3fd52e29c1e40b7cb212eb6d4 
> 
> Diff: https://git.reviewboard.kde.org/r/116911/diff/
> 
> 
> Testing
> -------
> 
> Proper menu entries are created in the Applet on adding, removing presences in contact list
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140321/880d9dda/attachment.html>