Review Request 116911: Use the newly moved PresenceModel from K-C-I

[Martin Klapetek]

> On March 20, 2014, 10:14 a.m., Martin Klapetek wrote:
> > presence/src/presence-applet.cpp, lines 49-54
> > <https://git.reviewboard.kde.org/r/116911/diff/1/?file=255400#file255400line49>
> >
> >     Why this change?
> 
> Siddhartha Sahu wrote:
>     It is a pedantic change. The includes are then in the order Qt -> KDE -> Tp -> KTp

What we do in KDE is usually the opposite; local includes -> KDE includes -> Qt includes (from most local to most system)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116911/#review53482
-----------------------------------------------------------


On March 19, 2014, 11:07 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116911/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 11:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> PresenceModel was moved from ktp-contact-list to ktp-common-internals. Using that.
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.h 76a1e36a61b5e9ed8ed2b2525a1c4f3e5b470671 
>   presence/src/presence-applet.cpp 7fe049617fb426f3fd52e29c1e40b7cb212eb6d4 
> 
> Diff: https://git.reviewboard.kde.org/r/116911/diff/
> 
> 
> Testing
> -------
> 
> Proper menu entries are created in the Applet on adding, removing presences in contact list
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140321/8bbcbaef/attachment-0001.html>