Review Request 116846: Contact list does not show settings-button, if its to narrow

[Martin Klapetek]

> On March 17, 2014, 10:09 a.m., Martin Klapetek wrote:
> > Good stuff! Can you try also setting a text to that action so that when you expand the toolbar, it actually says "Settings" next to the icon? Or any better string? Then upload again the screenshot with the toolbar extended.
> > 
> > /me is also wondering if we can make it proper submenu, without the need to click on the button to expand it...
> 
> Nilesh Suthar wrote:
>     I tried adding "Settings" text beside icon but there is no signal that is triggered when toolbar size is reduced such that the extender icon appears.These is how it looks then 
>     http://imgur.com/HuFgdWS
>     http://imgur.com/Sb64qbk
>     
>     If we trigger clicked handler on hovering then it cloud look like submenu.I am trying with QToolButton::leaveEvent(QEvent *) But it is not working.Can you help?.
>
> 
> Martin Klapetek wrote:
>     Ah hm, the text thing happens because it's a QWidgetAction. This approach does not look too good, especially when needing to deal with events (also visually). Let's try the other way, figure out if we can make the toolbar direct child of the window, then it should all work magically.
>     
>     I would suggest to try setting the parent of the toolbar to this->window() first and see if it works, if not, then the next way would be QWindow::addToolBar() but I'm afraid that would screw the layout. Might be tricky. In any case, keep this patch around, we might get back to it if the QWindow thing will fail.
> 
> Nilesh Suthar wrote:
>     Now it look like this.I tried the KComboBox is shown after QToolBar.Just set parent of toolbar to this->window() and added new toolbar.
>     
>     http://imgur.com/2yljaSN
>     http://imgur.com/gAowgpA
>     
>

That's what I was afraid of :/ I'll have to think about how to best handle this. I'll get back to you.

Good work though! Thanks


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116846/#review53161
-----------------------------------------------------------


On March 17, 2014, 6:45 a.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116846/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 6:45 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Bugs: 316591
>     http://bugs.kde.org/show_bug.cgi?id=316591
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Implemented SettingWidgetAction class by extending QWidgetAction. As during narrowing QToolBar populate only actions.So now by Extending QWidgetAction.We have implement Action with custom wigdet.
> 
> 
> Diffs
> -----
> 
>   main-widget.h aa69daa 
>   main-widget.cpp 27a941d 
> 
> Diff: https://git.reviewboard.kde.org/r/116846/diff/
> 
> 
> Testing
> -------
> 
> Working fine.
> 
> 
> File Attachments
> ----------------
> 
> Regular View.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/b249cfb9-7a6f-47ac-bb5c-f50eb23872ed__Regular_View.png
> Window narrowed.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/ecc5af4a-0766-4608-8596-fe39da54a950__Window_narrowed.png
> Window narrow arrow clicked.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/c77d661f-0480-4f22-b677-417e215f7f01__Window_narrow_arrow_clicked.png
> Window narrow setting clicked.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/a3ec661f-52e2-48a4-8073-c276d0093e60__Window_narrow_setting_clicked.png
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140318/7c04e3b2/attachment.html>