<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116846/">https://git.reviewboard.kde.org/r/116846/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 17th, 2014, 10:09 a.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good stuff! Can you try also setting a text to that action so that when you expand the toolbar, it actually says "Settings" next to the icon? Or any better string? Then upload again the screenshot with the toolbar extended.
/me is also wondering if we can make it proper submenu, without the need to click on the button to expand it...</pre>
</blockquote>
<p>On March 18th, 2014, 1:55 p.m. CET, <b>Nilesh Suthar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried adding "Settings" text beside icon but there is no signal that is triggered when toolbar size is reduced such that the extender icon appears.These is how it looks then
http://imgur.com/HuFgdWS
http://imgur.com/Sb64qbk
If we trigger clicked handler on hovering then it cloud look like submenu.I am trying with QToolButton::leaveEvent(QEvent *) But it is not working.Can you help?.
</pre>
</blockquote>
<p>On March 18th, 2014, 2:04 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah hm, the text thing happens because it's a QWidgetAction. This approach does not look too good, especially when needing to deal with events (also visually). Let's try the other way, figure out if we can make the toolbar direct child of the window, then it should all work magically.
I would suggest to try setting the parent of the toolbar to this->window() first and see if it works, if not, then the next way would be QWindow::addToolBar() but I'm afraid that would screw the layout. Might be tricky. In any case, keep this patch around, we might get back to it if the QWindow thing will fail.</pre>
</blockquote>
<p>On March 18th, 2014, 2:35 p.m. CET, <b>Nilesh Suthar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now it look like this.I tried the KComboBox is shown after QToolBar.Just set parent of toolbar to this->window() and added new toolbar.
http://imgur.com/2yljaSN
http://imgur.com/gAowgpA
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's what I was afraid of :/ I'll have to think about how to best handle this. I'll get back to you.
Good work though! Thanks</pre>
<br />
<p>- Martin</p>
<br />
<p>On March 17th, 2014, 6:45 a.m. CET, Nilesh Suthar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Martin Klapetek.</div>
<div>By Nilesh Suthar.</div>
<p style="color: grey;"><i>Updated March 17, 2014, 6:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316591">316591</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented SettingWidgetAction class by extending QWidgetAction. As during narrowing QToolBar populate only actions.So now by Extending QWidgetAction.We have implement Action with custom wigdet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Working fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main-widget.h <span style="color: grey">(aa69daa)</span></li>
<li>main-widget.cpp <span style="color: grey">(27a941d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116846/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/b249cfb9-7a6f-47ac-bb5c-f50eb23872ed__Regular_View.png">Regular View.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/ecc5af4a-0766-4608-8596-fe39da54a950__Window_narrowed.png">Window narrowed.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/c77d661f-0480-4f22-b677-417e215f7f01__Window_narrow_arrow_clicked.png">Window narrow arrow clicked.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/17/a3ec661f-52e2-48a4-8073-c276d0093e60__Window_narrow_setting_clicked.png">Window narrow setting clicked.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>