Review Request 116769: use TelepathyQt4Farstream pkg-config flags

[Diane Trout]

> On March 12, 2014, 9:04 a.m., David Edmundson wrote:
> >
> 
> Diane Trout wrote:
>     Doesn't libqtf stand for lib-qt-farstream? it seems odd to need to modify the includes to need to include itself.

Ah I was wrong. ktp-call-ui/libqtf contains small stubs that connects the TelepathyQt/Farstream classes to the QGlib type-system. It makes sense to me to ask TelepathyQt what farstream library it was linked against.

It does look like that information isn't available in TelepathyQt4Farstream.cmake

I think just using TP_QT4_FARSTREAM_LDFLAGS works because ktp-call-ui picks up telepathy-farstream from telepathy-qt4-farstream. I'm not sure if the build process should be told explicitly that it should link against both telepathy-qt4-farstream and telepathy-farstream.

My partial, and I now think somewhat incorrect solution for debian was to set the cmake flags:

CMAKE_FLAGS := \
    -DTP_FARSTREAM_INCLUDE_DIRS=/usr/include/telepathy-1.0 \
    -DDBUS_INCLUDE_DIR=/usr/include/dbus-1.0

I think I also need to set the TP_FARSTREAM_LDFLAGS during the cmake configuration step.


- Diane


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116769/#review52810
-----------------------------------------------------------


On March 12, 2014, 8:53 a.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116769/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 8:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Use TelepathyQt4Farstream pkg-config flags instead of telepathy-farstream.  In a perfect world these match,
> but when/if one has to install telepathy-farstream-0.4 in parallel and/or in a different place than telepathy-qt, things go wrong.
> 
> This is one small step in fixing
> BUG: 312450
> 
> 
> Diffs
> -----
> 
>   libqtf/CMakeLists.txt 38d234b 
> 
> Diff: https://git.reviewboard.kde.org/r/116769/diff/
> 
> 
> Testing
> -------
> 
> Been using this to build ktp-call-ui packages in fedora for quite awhile, due to having to install telepathy-farstream-0.4 in parallel (and in a different header prefix) to newer gst1-based telepathy-farstream-0.6
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140313/64592bdf/attachment-0001.html>