<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116769/">https://git.reviewboard.kde.org/r/116769/</a>
</td>
</tr>
</table>
<br />
<p>On March 12th, 2014, 12:59 p.m. PDT, <b>Diane Trout</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't libqtf stand for lib-qt-farstream? it seems odd to need to modify the includes to need to include itself.</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah I was wrong. ktp-call-ui/libqtf contains small stubs that connects the TelepathyQt/Farstream classes to the QGlib type-system. It makes sense to me to ask TelepathyQt what farstream library it was linked against.
It does look like that information isn't available in TelepathyQt4Farstream.cmake
I think just using TP_QT4_FARSTREAM_LDFLAGS works because ktp-call-ui picks up telepathy-farstream from telepathy-qt4-farstream. I'm not sure if the build process should be told explicitly that it should link against both telepathy-qt4-farstream and telepathy-farstream.
My partial, and I now think somewhat incorrect solution for debian was to set the cmake flags:
CMAKE_FLAGS := \
-DTP_FARSTREAM_INCLUDE_DIRS=/usr/include/telepathy-1.0 \
-DDBUS_INCLUDE_DIR=/usr/include/dbus-1.0
I think I also need to set the TP_FARSTREAM_LDFLAGS during the cmake configuration step.
</pre>
<br />
<p>- Diane</p>
<br />
<p>On March 12th, 2014, 8:53 a.m. PDT, Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated March 12, 2014, 8:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-call-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use TelepathyQt4Farstream pkg-config flags instead of telepathy-farstream. In a perfect world these match,
but when/if one has to install telepathy-farstream-0.4 in parallel and/or in a different place than telepathy-qt, things go wrong.
This is one small step in fixing
BUG: 312450
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been using this to build ktp-call-ui packages in fedora for quite awhile, due to having to install telepathy-farstream-0.4 in parallel (and in a different header prefix) to newer gst1-based telepathy-farstream-0.6</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libqtf/CMakeLists.txt <span style="color: grey">(38d234b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116769/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>