Review Request 115425: Activate / deactivate Now Playing globally in KConfig when setting playback status in the contact list

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115425/
-----------------------------------------------------------

(Updated March 3, 2014, 7:30 a.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

Elaborate ticket with latest diff removing new string and dialog box.

Can someone confirm the contact list is actually well enough interacting with the kded module for .8? If not please commit this patch with review as it is functionally on par with the current code but omits the dialog requesting attention when engaging the nowplaying plugin. At some future time I would like to have the dialog warning the user about custom status message interaction when engaging status message plugins restored.


Repository: ktp-contact-list


Description (updated)
-------

Enables / disables Now Playing in systemsettings every time it is enabled / disabled in the contact list.

Fixes systemsettings kcm showing nowplaying enabled while the contact list has disabled its functionality.

Also fixes state selection affinity for certain actions in the contact list for interacting with .8 kded module.


Diffs
-----

  global-presence-chooser.h c240682 
  global-presence-chooser.cpp 2047473 

Diff: https://git.reviewboard.kde.org/r/115425/diff/


Testing
-------

Compile, run.


File Attachments
----------------

What the presence changer looks like
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/19/bff7b099-8e07-454d-a49a-f7151941645a__contactlistpresencechanger.png
What the custom status message dialog looks like (not in the latest revision)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/19/062d62a1-46a9-41e6-8144-9c16b330a2be__contactlistsorryactiveplugin.png


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140303/7522cdae/attachment-0001.html>