<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115425/">https://git.reviewboard.kde.org/r/115425/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Martin Klapetek.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated March 3, 2014, 7:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Elaborate ticket with latest diff removing new string and dialog box.
Can someone confirm the contact list is actually well enough interacting with the kded module for .8? If not please commit this patch with review as it is functionally on par with the current code but omits the dialog requesting attention when engaging the nowplaying plugin. At some future time I would like to have the dialog warning the user about custom status message interaction when engaging status message plugins restored.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enables / disables Now Playing in systemsettings every time it is enabled / disabled in the contact list.
Fixes systemsettings kcm showing nowplaying enabled while the contact list has disabled its functionality.
Also fixes state selection affinity for certain actions in the contact list for interacting with .8 kded module.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile, run.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>global-presence-chooser.h <span style="color: grey">(c240682)</span></li>
<li>global-presence-chooser.cpp <span style="color: grey">(2047473)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115425/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/19/bff7b099-8e07-454d-a49a-f7151941645a__contactlistpresencechanger.png">What the presence changer looks like</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/19/062d62a1-46a9-41e6-8144-9c16b330a2be__contactlistsorryactiveplugin.png">What the custom status message dialog looks like (not in the latest revision)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>