Review Request 119460: GStreamer + Farstream Porting (mostly Diane's work)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119460/#review63134
-----------------------------------------------------------

Ship it!


This is good to go for me, I remember reading through when Diane made these changes.


libqtf/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119460/#comment43885>

    Can we/do we want to check for > 0.2.3 I remember someone saying anything lower was rubbish.


- David Edmundson


On July 25, 2014, 11:15 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119460/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 11:15 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Remove postproc_tmpnoise from TfVideoContentHandler::createSrcBin
> 
> I couldn't find an equivalent for gstreamer 1.0, so I removed it.
> Though I left a note in case someone finds a replacement
> 
> gstreamer 1.0 may have a replacement in the smooth plugin.
> 
> 
> videomaxrate seems to have been generalized into videorate.
> 
> this attempts to configure videorate to act like videomaxrate did.
> 
> 
> Update cmake to look for farstream 0.2
> 
> 
> ffmpegcolorspace -> videoconvert
> 
> Port to QtGstreamer1.0
> 
> 
> rename caps type name removing 0.10 format
> 
> Also simplify the audio caps
> 
> 
> rename enable-last-buffer to enable-last-sample
> 
> 
> Rename src%d to src_%u.
> 
> The gstreamer 1.0 documentation suggests the _ is inconsistently
> used. (Though they did want to use %u for unsigned values.)
> 
> 
> Require farstream 0.2
> 
> 
> Diffs
> -----
> 
>   libktpcall/CMakeLists.txt 354710a 
>   libktpcall/private/sink-controllers.cpp 3b067d1 
>   libktpcall/private/tf-audio-content-handler.cpp e9cf9f3 
>   libktpcall/private/tf-video-content-handler.cpp c9789f5 
>   libktpcall/private/video-sink-bin.cpp 57f47b1 
>   libqtf/CMakeLists.txt 38d234b 
> 
> Diff: https://git.reviewboard.kde.org/r/119460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140725/9a4973b3/attachment.html>