<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119460/">https://git.reviewboard.kde.org/r/119460/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is good to go for me, I remember reading through when Diane made these changes.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119460/diff/1/?file=292627#file292627line6" style="color: black; font-weight: bold; text-decoration: underline;">libqtf/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">pkg_check_modules</span><span class="p">(</span><span class="s">FARSTREAM</span> <span class="s">REQUIRED</span> <span class="s">farstream-0.<span class="hl">1</span></span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">pkg_check_modules</span><span class="p">(</span><span class="s">FARSTREAM</span> <span class="s">REQUIRED</span> <span class="s">farstream-0.<span class="hl">2</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can we/do we want to check for > 0.2.3 I remember someone saying anything lower was rubbish.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On July 25th, 2014, 11:15 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 25, 2014, 11:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-call-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove postproc_tmpnoise from TfVideoContentHandler::createSrcBin
I couldn't find an equivalent for gstreamer 1.0, so I removed it.
Though I left a note in case someone finds a replacement
gstreamer 1.0 may have a replacement in the smooth plugin.
videomaxrate seems to have been generalized into videorate.
this attempts to configure videorate to act like videomaxrate did.
Update cmake to look for farstream 0.2
ffmpegcolorspace -> videoconvert
Port to QtGstreamer1.0
rename caps type name removing 0.10 format
Also simplify the audio caps
rename enable-last-buffer to enable-last-sample
Rename src%d to src_%u.
The gstreamer 1.0 documentation suggests the _ is inconsistently
used. (Though they did want to use %u for unsigned values.)
Require farstream 0.2
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libktpcall/CMakeLists.txt <span style="color: grey">(354710a)</span></li>
<li>libktpcall/private/sink-controllers.cpp <span style="color: grey">(3b067d1)</span></li>
<li>libktpcall/private/tf-audio-content-handler.cpp <span style="color: grey">(e9cf9f3)</span></li>
<li>libktpcall/private/tf-video-content-handler.cpp <span style="color: grey">(c9789f5)</span></li>
<li>libktpcall/private/video-sink-bin.cpp <span style="color: grey">(57f47b1)</span></li>
<li>libqtf/CMakeLists.txt <span style="color: grey">(38d234b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119460/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>