Review Request 119086: Added disabling/enabling logging for specified entities

[Dan Vrátil]

> On July 8, 2014, 8:14 a.m., Dan Vrátil wrote:
> > The TPLQT_TPL_IS_VERSION macro is defined in log-manager.h, which is public, so you can safely use it here too. Just do something like
> > ```
> > #if TPLQT_TPL_IS_VERSION(0, 9, 0)
> >   code
> > #else
> >   return defualtValue;
> > #endif
> > ```
> > 
> > In all three TpLoggerPlugin methods implementations.
> 
> Marcin Ziemiński wrote:
>     TPLQT_TPL_IS_VERSION macro needs TPLQT_TPL_VERSION_MAJOR, ...MINOR, ...PATCH definitions to be provided during compilation.Everything will compile fine but with numerous warnings.

Sorry for taking so long.

Maybe the ```TPLQT_TPL_VERSION_*``` variables could be provided by TelepathyLoggerConfig.cmake?


For the warnings, just add Q_UNUSED(arg) into the #else branch of the example in my previous comment ;-)


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119086/#review61873
-----------------------------------------------------------


On July 7, 2014, 7:37 p.m., Marcin Ziemiński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119086/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 7:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an option to disable or enable logging for entities with an implementation in tp-logger-plugin. 
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp 8c0cb16 
>   KTp/Logger/abstract-logger-plugin.h 6db98d4 
>   KTp/Logger/abstract-logger-plugin.cpp 6d387bb 
>   KTp/Logger/log-manager.h c5f92d6 
>   KTp/Logger/log-manager.cpp 7ce4a12 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.h 346c233 
> 
> Diff: https://git.reviewboard.kde.org/r/119086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marcin Ziemiński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140714/a465f021/attachment.html>