Review Request 118747: Bug 333527 - re-enabling e-mail processing in the message escape filter

Martin Klapetek martin.klapetek at gmail.com
Thu Jul 10 10:02:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118747/#review62056
-----------------------------------------------------------


Can you confirm https://bugs.kde.org/show_bug.cgi?id=310502 does not happen anymore with this patch?

- Martin Klapetek


On June 14, 2014, 8:29 p.m., Olaf Piesche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118747/
> -----------------------------------------------------------
> 
> (Updated June 14, 2014, 8:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 333527
>     http://bugs.kde.org/show_bug.cgi?id=333527
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Removed the if excluding mailto: links from going through the filter, so e-mails show as links again in the message window. The diff is a little wonky for whatever reason, simply removed the if in line 57 and the corresponding scope brackets.
> 
> 
> Diffs
> -----
> 
>   KTp/message-escape-filter.cpp 93513f2 
> 
> Diff: https://git.reviewboard.kde.org/r/118747/diff/
> 
> 
> Testing
> -------
> 
> Sent e-mail addresses back and forth in various combinations with text. 
> 
> 
> Thanks,
> 
> Olaf Piesche
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140710/bda0cca5/attachment.html>


More information about the KDE-Telepathy mailing list