Review Request 119086: Added disabling/enabling logging for specified entities

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119086/#review61567
-----------------------------------------------------------


Few small nitpicks from me, otherwise it looks OK.


KTp/Logger/abstract-logger-plugin.h
<https://git.reviewboard.kde.org/r/119086/#comment42851>

    Please add that it "returns false if the operation fails or is not supported by the backend" to this and other methods to make it clear that this feature might not be always supported.



KTp/Logger/log-manager.cpp
<https://git.reviewboard.kde.org/r/119086/#comment42853>

    Missing space after "if"



KTp/Logger/log-manager.cpp
<https://git.reviewboard.kde.org/r/119086/#comment42852>

    Missing space after "if"


- Dan Vrátil


On July 3, 2014, 3:19 p.m., Marcin Ziemiński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119086/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 3:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an option to disable or enable logging for entities with an implementation in tp-logger-plugin. 
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp 8c0cb16 
>   KTp/Logger/log-manager.cpp 7ce4a12 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.h 346c233 
>   KTp/Logger/log-manager.h c5f92d6 
>   KTp/Logger/abstract-logger-plugin.cpp 6d387bb 
>   KTp/Logger/abstract-logger-plugin.h 6db98d4 
> 
> Diff: https://git.reviewboard.kde.org/r/119086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marcin Ziemiński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140703/6329c1ae/attachment.html>