Review Request 119086: Added disabling/enabling logging for specified entities

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119086/#review61553
-----------------------------------------------------------



KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp
<https://git.reviewboard.kde.org/r/119086/#comment42848>

    Qt guidelines says to avoid negatives in your method names
    
    i.e use
    
    isLogginedEnabled rather than isLoggingDisabled.
    
    
    


- David Edmundson


On July 3, 2014, 1:19 p.m., Marcin Ziemiński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119086/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 1:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an option to disable or enable logging for entities with an implementation in tp-logger-plugin. 
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp 8c0cb16 
>   KTp/Logger/log-manager.cpp 7ce4a12 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.h 346c233 
>   KTp/Logger/log-manager.h c5f92d6 
>   KTp/Logger/abstract-logger-plugin.cpp 6d387bb 
>   KTp/Logger/abstract-logger-plugin.h 6db98d4 
> 
> Diff: https://git.reviewboard.kde.org/r/119086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marcin Ziemiński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140703/6aa67ed0/attachment.html>