Review Request 115060: Save all persistent information on a contact to a database

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115060/#review47901
-----------------------------------------------------------


Idea is good, needs a tiny bit of work, details below ;)


contact-cache.h
<https://git.reviewboard.kde.org/r/115060/#comment33909>

    Remove or fill in



contact-cache.h
<https://git.reviewboard.kde.org/r/115060/#comment33910>

    As all of ktp is LGPL, change to LGPL too..?



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33911>

    either put space between arguments in SIGNAL and SLOT or put no space in both places ;) Actually I think there should be no space for optimization



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33915>

    ...and the coding style! ;)
    
    In constructor too.



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33914>

    If you have your facebook enabled and one or more accounts, this might get really slow for just one contact as it will re-insert every contact because of just one. Would it be worth actually caching the ID and checking before inserting? ID should be enough because that would give you just a couple of re-inserts, compared to hundreds.



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33913>

    How fast is this? Will this in any way block kded?


- Martin Klapetek


On Jan. 16, 2014, 9:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115060/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 9:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Save all persistent information on a contact to a database
> 
> In KPeople we need the name + avatar of a person even when the
> user is offline. The only approach is to have a small cache.
> 
> This is apparently being merged into Telepathy at some point,
> so we maybe remove this in future
> 
> ----
> 
> Won't merge till we make the relevant change in the kpeople plugin too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a31245b 
>   contact-cache.h PRE-CREATION 
>   contact-cache.cpp PRE-CREATION 
>   contactnotify.cpp 314d48a 
>   telepathy-module.cpp a754283 
> 
> Diff: https://git.reviewboard.kde.org/r/115060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140121/898e2293/attachment-0001.html>