Review Request 115060: Save all persistent information on a contact to a database

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115060/#review47898
-----------------------------------------------------------

Ship it!


Seems good to me


contact-cache.h
<https://git.reviewboard.kde.org/r/115060/#comment33903>

    Same line?



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33904>

    I see you're using a different email address now. Also, it's now 2014



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33908>

    Are you sure this compiles?
    
    This line is missing a closing parenthesis.



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33907>

    I'm not sure if this can actually happen, but if a contact is removed and then added, we may get it in both the lists, in that case we want to first remove all the data and then insert it.



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33906>

    I think there should be a space between the Q_FOREACH and (, but since the other files seems to be using the same style, it might not make sense to change it.



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115060/#comment33905>

    Is this really required?


- Vishesh Handa


On Jan. 16, 2014, 8:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115060/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 8:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Save all persistent information on a contact to a database
> 
> In KPeople we need the name + avatar of a person even when the
> user is offline. The only approach is to have a small cache.
> 
> This is apparently being merged into Telepathy at some point,
> so we maybe remove this in future
> 
> ----
> 
> Won't merge till we make the relevant change in the kpeople plugin too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a31245b 
>   contact-cache.h PRE-CREATION 
>   contact-cache.cpp PRE-CREATION 
>   contactnotify.cpp 314d48a 
>   telepathy-module.cpp a754283 
> 
> Diff: https://git.reviewboard.kde.org/r/115060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140121/5bfcd1d3/attachment.html>